Skip to content

✨ Logger system#1

Merged
pierrocknroll merged 4 commits into
mainfrom
feature/logger
Apr 9, 2025
Merged

✨ Logger system#1
pierrocknroll merged 4 commits into
mainfrom
feature/logger

Conversation

@pierrocknroll
Copy link
Copy Markdown
Contributor

@pierrocknroll pierrocknroll commented Apr 4, 2025

Pull Request

Description

Introduce a logger system based on our project template with Copier.
This project could be used in other projects who need logging system.

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality
    to not work as expected)
  • 📝 Documentation update
  • ♻️ Code refactor
  • ⚡ Performance improvement
  • 🧪 Test implementation/update
  • 🔧 Configuration change
  • 🔄 CI/CD related changes

How Has This Been Tested?

  • Unit tests
  • Integration tests
  • Manual tests
  • Other (please specify):

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pierrocknroll pierrocknroll self-assigned this Apr 4, 2025
@pierrocknroll pierrocknroll added the enhancement New feature or request label Apr 4, 2025
@pierrocknroll pierrocknroll requested a review from guilfb April 4, 2025 13:47
Copy link
Copy Markdown

@guilfb guilfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there,

Great PR here. This project will be very useful for all our Python projects.
It is also well documented, and well tested as well.
Just a few comments about consistency details.

Many thanks

Comment thread tests/logger/loguru_test.py
Comment thread tests/conftest.py
Comment thread tests/logger/loggable_mixin_test.py
@pierrocknroll pierrocknroll merged commit 9f0440b into main Apr 9, 2025
@pierrocknroll pierrocknroll deleted the feature/logger branch July 17, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants